Ubospica commented on code in PR #16039:
URL: https://github.com/apache/tvm/pull/16039#discussion_r1382714604
##########
include/tvm/target/tag.h:
##########
@@ -131,6 +137,11 @@ inline TargetTagRegEntry&
TargetTagRegEntry::set_config(Map<String, ObjectRef> c
return *this;
}
+inline TargetTagRegEntry& TargetTagRegEntry::add_config(String key, ObjectRef
value) {
Review Comment:
> I think this is pretty much the same as `set_config` where you can just do
>
> ```c++
> target.set_config({key, value});
> ```
>
> Another example can be found here:
>
>
https://github.com/apache/tvm/blob/c3ce474dc172c521d7057061fac3b21207e83f0d/src/target/tag.cc#L73-L88
Thanks for the comment. But the problem here is using set_config will
**substitute** the whole config map instread of adding new items. And for macro
TVM_REGISTER_CUDA_TAG, a config is already added. See
https://github.com/apache/tvm/blob/c3ce474dc172c521d7057061fac3b21207e83f0d/src/target/tag.cc#L109-L118
So maybe we need to find a method to add an additional config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
