zxybazh commented on code in PR #16039:
URL: https://github.com/apache/tvm/pull/16039#discussion_r1384216636
##########
src/target/target_kind.cc:
##########
@@ -334,6 +334,7 @@ TVM_REGISTER_TARGET_KIND("cuda", kDLCUDA)
.add_attr_option<Integer>("max_threads_per_block")
.add_attr_option<Integer>("thread_warp_size", Integer(32))
.add_attr_option<Integer>("registers_per_block")
+ .add_attr_option<Integer>("l2_cache_size_bytes")
Review Comment:
Hi, as I mentioend in the beginning of this commen, I was just nit picking
and I don't have strong opinion if you prefer to keep it. On the other hand, I
don't think any naming for this would impact your cross compilation usage, just
make sure you have consistent naming with Zihao's PR should be good.
##########
src/target/target_kind.cc:
##########
@@ -334,6 +334,7 @@ TVM_REGISTER_TARGET_KIND("cuda", kDLCUDA)
.add_attr_option<Integer>("max_threads_per_block")
.add_attr_option<Integer>("thread_warp_size", Integer(32))
.add_attr_option<Integer>("registers_per_block")
+ .add_attr_option<Integer>("l2_cache_size_bytes")
Review Comment:
Hi, as I mentioend in the beginning of this comment, I was just nit picking
and I don't have strong opinion if you prefer to keep it. On the other hand, I
don't think any naming for this would impact your cross compilation usage, just
make sure you have consistent naming with Zihao's PR should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
