gmeeker commented on code in PR #16357:
URL: https://github.com/apache/tvm/pull/16357#discussion_r1448231582
##########
python/tvm/rpc/server.py:
##########
@@ -119,6 +119,15 @@ def download_linked_module(file_name):
return temp
+def _serve_loop(sock, load_library, work_path=None):
+ """Server loop"""
+ sockfd = sock.fileno()
+ temp = _server_env(load_library, work_path)
+ _ffi_api.ServerLoop(sockfd)
+ if not work_path:
+ temp.remove()
Review Comment:
The answer to most of your comments is that I reverted part of
(https://github.com/apache/tvm/pull/15187) so that _server_loop can be pickled.
The code here comes from the code before that commit, and I didn't simplify it.
I assumed there was a reason for its style, but I'll take another pass at this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
