gmeeker commented on code in PR #16357:
URL: https://github.com/apache/tvm/pull/16357#discussion_r1448236114
##########
python/tvm/rpc/server.py:
##########
@@ -119,6 +119,15 @@ def download_linked_module(file_name):
return temp
+def _serve_loop(sock, load_library, work_path=None):
Review Comment:
The earlier code that I copied from used "sock" to refer to the socket and
"conn" to refer to the resulting object from accept(). The current code uses
"sock" everywhere, as in "socket object" but not the same object throughout. It
sounds like you prefer that?
No, I'm not sure why work_path was optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
