vinx13 commented on code in PR #16548:
URL: https://github.com/apache/tvm/pull/16548#discussion_r1483630704
##########
src/target/source/codegen_cuda.cc:
##########
@@ -271,12 +289,19 @@ void CodeGenCUDA::PrintType(DataType t, std::ostream& os)
{ // NOLINT(*)
}
if (!fail) return;
} else if (t.is_float8()) {
+ enable_fp8_ = true;
+ std::string vec;
if (t.is_scalar()) {
- os << "unsigned char"; // __nv_fp8_storage_t is an alias of unsigned
char
+ vec = "";
} else if (lanes == 2) {
- os << "unsigned short int"; // __nv_fp8x2_storage_t is an alias of
unsigned short
+ vec = "2_";
} else if (lanes == 4) {
- os << "unsigned int"; // __nv_fp8x4_storage_t is an alias of unsigned
int
+ vec = "x4";
Review Comment:
this should be `_2` / `_4` according to the declaration above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
