csullivan commented on code in PR #16548:
URL: https://github.com/apache/tvm/pull/16548#discussion_r1520837350
##########
src/target/llvm/codegen_llvm.cc:
##########
@@ -594,6 +596,7 @@ llvm::Type* CodeGenLLVM::DTypeToLLVMType(const DataType&
dtype) const {
return llvm::VectorType::get(etype, dtype.lanes());
#endif
} else {
+ ICHECK(etype != nullptr) << "No suitable llvm type found for dtype: " <<
dtype;
Review Comment:
Thank you @vinx13. I was trying to leave the code better than I found it,
but I guess some downstream handling is relying on this behavior. I have
removed the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
