Lunderberg commented on code in PR #16642:
URL: https://github.com/apache/tvm/pull/16642#discussion_r1504405971
##########
python/tvm/relax/transform/transform.py:
##########
@@ -463,6 +463,16 @@ def KillAfterLastUse() -> tvm.ir.transform.Pass:
return _ffi_api.KillAfterLastUse() # type: ignore
+def ComputePrimValue() -> tvm.ir.transform.Pass:
+ """Compute all R.prim_value instances
Review Comment:
Good point on improving the docstring.
Regarding phase ordering, I don’t think we need to restrict its usage. The
calls to PrimFunc instances are valid in user-provided Relax functions, so this
could occur early in the phase ordering. The only limitation is that it must
occur before `VMShapeLower`, as `VMShapeLower` expects all `R.prim_value(arg)`
expressions to have int64 arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
