slyubomirsky commented on code in PR #16642:
URL: https://github.com/apache/tvm/pull/16642#discussion_r1505049818


##########
python/tvm/relax/transform/transform.py:
##########
@@ -463,6 +463,16 @@ def KillAfterLastUse() -> tvm.ir.transform.Pass:
     return _ffi_api.KillAfterLastUse()  # type: ignore
 
 
+def ComputePrimValue() -> tvm.ir.transform.Pass:
+    """Compute all R.prim_value instances

Review Comment:
   Are they truly pure? No modification of external values?
   
   Edit: Yeah, they just use a return value. I imagine this means that we 
actually have to check the bodies of PrimFuncs to determine if they're pure and 
also give users the option to override the automatic judgment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to