Lunderberg commented on PR #16642: URL: https://github.com/apache/tvm/pull/16642#issuecomment-1973333283
> Do you think it's necessary to have an override to assert a PrimFunc is pure? I think I prefer having the overrides at an individual operator level, rather than on the function as a whole. So, a user could use `T.call_pure_packed` instead of `T.call_packed`, in order to make the overall function be marked as pure. Especially when inlining/extracting regions of a function (e.g. `SplitHostDevice`), the top-down annotations can be ambiguous. Relying on bottom-up annotations allows each extracted region to have correct annotations, without requiring the developer to explicitly propagate function-level annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
