Lunderberg commented on code in PR #16687:
URL: https://github.com/apache/tvm/pull/16687#discussion_r1526290577
##########
include/tvm/relax/expr.h:
##########
@@ -983,16 +983,21 @@ class FunctionNode : public BaseFuncNode {
class Function : public BaseFunc {
public:
TVM_DLL explicit Function(Array<Var> params, Expr body, Optional<StructInfo>
ret_struct_info,
- bool is_pure = true, DictAttrs attrs =
NullValue<DictAttrs>(),
- Span span = Span());
+ bool is_pure, DictAttrs attrs =
NullValue<DictAttrs>(),
+ Span span = Span())
+ : Function(params, body, ret_struct_info, Optional<Bool>(Bool(is_pure)),
attrs, span) {}
+
+ TVM_DLL explicit Function(Array<Var> params, Expr body,
+ Optional<StructInfo> ret_struct_info = NullOpt,
+ Optional<Bool> is_pure = NullOpt,
+ DictAttrs attrs = NullValue<DictAttrs>(), Span
span = Span());
/*!
* \brief Mimics the constructor but without body Expr.
- * \note ret_struct_info is required, since it can not deduced by the body.
+ * \note `ret_struct_info` and `is_pure` are required, since it can not
deduced by the body.
Review Comment:
Good catch, and corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
