cbalint13 commented on PR #16425:
URL: https://github.com/apache/tvm/pull/16425#issuecomment-2023330146

   > This PR causes spurious error messages to be printed when loading 
`libtvm.so`, when the local version of LLVM available does not support one of 
the CPU architectures defined in 
[`tag.cc`](https://github.com/apache/tvm/blob/main/src/target/tag.cc#L85). For 
example, the following error messages are printed when LLVM 10.0 is used.
   > 
   > 
![image](https://private-user-images.githubusercontent.com/3888575/317360495-27667925-31b4-4597-9bbe-6c0e25ea8868.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE1NTg3MjgsIm5iZiI6MTcxMTU1ODQyOCwicGF0aCI6Ii8zODg4NTc1LzMxNzM2MDQ5NS0yNzY2NzkyNS0zMWI0LTQ1OTctOWJiZS02YzBlMjVlYTg4NjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMjdUMTY1MzQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmJiMjJiODQ2ODEwMDVjNGVkODQ2NTk5OWQ0ZjJiYTNhMDE0YzQ4NjRkZDIxMjAzOTlmZmEyOWQ0ZWUyODYyNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.-Y8YL8gUWXpDwOJZL0J2G4NAmTc8DBc91XvfRTjbC8E)
   
   Hi @Lunderberg ,
   
   The messages looks legit, LLVM10 not support those CPU invocations.
   * The message maybe could be more explicit by adding **"using LLVM version 
X.Y"** like e.g.:
      ```LLVM cpu architecture -mcpu=cortex-a78 is not valid in 
-mtriple=aarch64{...} using LLVM version X.Y```
   * Maybe also we could issue "WARN" instead of "ERROR" level here, but the 
user should be still notified somehow.
   
   ---
   
   This behaviour was intentionate and introduced [here @ 
PR#15761](https://github.com/apache/tvm/pull/15761/files#diff-f13c79368edd27b0c05d044df267746187448906d4310d5617bce89003b8813bR201-R210)
   With this ```#1571``` TVM has the ability to lookup into LLVM's *internal 
catalog* of arches, cpus and their exact features.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to