Lunderberg commented on code in PR #16827:
URL: https://github.com/apache/tvm/pull/16827#discussion_r1547685742


##########
src/script/printer/relax/tir.cc:
##########
@@ -41,9 +41,6 @@ RelaxFrameNode* GetRelaxFrame(IRDocsifier d) {
 }
 
 Doc PrintTIRVar(tir::Var n, ObjectPath n_p, IRDocsifier d) {
-  ICHECK(n->dtype.is_int() && n->dtype.is_scalar()) << "TypeError: Relax only 
uses "
-                                                       "scalar integer TIR 
variables, but gets: "
-                                                    << n;

Review Comment:
   Good point.  I needed to remove the `n->dtype.is_int()` check, as the value 
could be `R.Prim("float32")`, but the check for `n->dtype.is_scalar()` should 
be kept.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to