Lunderberg commented on code in PR #16827: URL: https://github.com/apache/tvm/pull/16827#discussion_r1550803183
########## tests/python/relax/test_op_binary.py: ########## @@ -184,10 +250,10 @@ def test_binary_infer_struct_info_shape_var(binary_arith_op: Callable): y4 = relax.Var("y", relax.TensorStructInfo(s4, "float32")) _check_inference(bb, binary_arith_op(x, y0), relax.TensorStructInfo(s0, "float32")) - _check_inference(bb, binary_arith_op(x, y1), relax.TensorStructInfo(dtype="float32", ndim=2)) - _check_inference(bb, binary_arith_op(x, y2), relax.TensorStructInfo(dtype="float32", ndim=4)) - _check_inference(bb, binary_arith_op(x, y3), relax.TensorStructInfo(dtype="float32", ndim=2)) - _check_inference(bb, binary_arith_op(x, y4), relax.TensorStructInfo(dtype="float32")) + # _check_inference(bb, binary_arith_op(x, y1), relax.TensorStructInfo(dtype="float32", ndim=2)) + # _check_inference(bb, binary_arith_op(x, y2), relax.TensorStructInfo(dtype="float32", ndim=4)) + # _check_inference(bb, binary_arith_op(x, y3), relax.TensorStructInfo(dtype="float32", ndim=2)) + # _check_inference(bb, binary_arith_op(x, y4), relax.TensorStructInfo(dtype="float32")) Review Comment: Thank you for the catch, and they are now uncommented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org