OttoWRas commented on PR #16766: URL: https://github.com/apache/tvm/pull/16766#issuecomment-2043476017
Hi @lhutton1, I just fixed the test, it actually seemed to already fail with out LLVM, but i just wasn't good enough at using the test system to realize. It seems like the test was misplaced, as there was a guarded area for LLVM dependent test, a few lines above the test. I added an `ASSERT`, instead of the previous check to make the test actually test something. But looking back on this issue, it seems to me like, `defined()` was either used wrong here, or it should be changed to be able to handle `null` and not only `null_pointer`'s. I hope this was what you meant, otherwise feel free to make your own changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
