lhutton1 commented on code in PR #16766:
URL: https://github.com/apache/tvm/pull/16766#discussion_r1557775990
##########
src/target/parsers/cpu.cc:
##########
@@ -29,10 +29,12 @@ namespace parsers {
namespace cpu {
Optional<String> DetectSystemTriple() {
+ #ifdef TVM_INFO_USE_LLVM
Review Comment:
I'm not too sure why, TVM_INFO_USE_LLVM doesn't seem to be declared when
USE_LLVM != OFF (I compiled with USE_LLVM=llvm-config-17). However, it seems
the more common approach in the codebase is to use #ifdef TVM_LLVM_VERSION
instead, so I didn't spend too much time investigating. Let's check for
TVM_LLVM_VERSION here (and in the other instances) instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
