cbalint13 commented on code in PR #17260:
URL: https://github.com/apache/tvm/pull/17260#discussion_r1713365517
##########
python/tvm/contrib/cc.py:
##########
@@ -373,7 +373,11 @@ def _linux_compile(
def _windows_compile(output, objects, options, cwd=None, ccache_env=None):
cmd = ["clang"]
+ compiler = os.getenv("TVM_WIN_CC", default="clang")
+ win_target = os.getenv("TVM_WIN_TARGET", default="x86_64")
+ cmd = [compiler]
cmd += ["-O2"]
+ cmd += ["--target=" + win_target]
Review Comment:
Let's also condition these too within the above comment.
##########
python/tvm/contrib/cc.py:
##########
@@ -373,7 +373,11 @@ def _linux_compile(
def _windows_compile(output, objects, options, cwd=None, ccache_env=None):
cmd = ["clang"]
+ compiler = os.getenv("TVM_WIN_CC", default="clang")
+ win_target = os.getenv("TVM_WIN_TARGET", default="x86_64")
+ cmd = [compiler]
Review Comment:
This overwrite initial ```cmd = [clang]``` initialization, in a
counterintuitive logic, could we condition the new assignment here to
```TVM_WIN_TARGET``` presence ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
