cbalint13 commented on code in PR #17260:
URL: https://github.com/apache/tvm/pull/17260#discussion_r1713377122
##########
python/tvm/contrib/cc.py:
##########
@@ -373,7 +373,11 @@ def _linux_compile(
def _windows_compile(output, objects, options, cwd=None, ccache_env=None):
cmd = ["clang"]
+ compiler = os.getenv("TVM_WIN_CC", default="clang")
+ win_target = os.getenv("TVM_WIN_TARGET", default="x86_64")
+ cmd = [compiler]
Review Comment:
Also lets fix ```cwd=None``` typo here, perhaps we could have
```cmd=[clang]``` (if you would like better) and then just override with
windows env related conditional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
