srkreddy1238 commented on PR #17599: URL: https://github.com/apache/tvm/pull/17599#issuecomment-2999679470
> Sorry for delaying get back because of the recent focus on FFI refactoring, I think the main remaining item is the following change > > > StructInfo infered_sinfo = infer_struct_info_map[op](GetRef(call), builder_); > > legalized = UpdateVDeviceOutStructInfo(legalized, visited_call, infered_sinfo); > > Where the struct info inference function was called during legalization (and I commented on that previously which might be overlooked). The primary principle we had is to automating struct info deduction during building, so in theory every pre-visit call already have struct info populated, and most rewrite should not change the struct info post visit. Doing explicit deduction within a rewrite a is a pattern we want to avoid Understood and the challenge lies in the legalization utils defined below which sets the output_sinfo (aka Vdevice info) derived from any one of its arguments instead of inferred from original operator infer API. I will improve this part ... https://github.com/apache/tvm/blob/437d00afcd5496700703427cc4ce316a35d35baa/python/tvm/relax/utils.py#L324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
