tqchen commented on code in PR #17599:
URL: https://github.com/apache/tvm/pull/17599#discussion_r2218992901
##########
ffi/cmake/Utils/AddLibbacktrace.cmake:
##########
@@ -26,6 +26,10 @@ function(_libbacktrace_compile)
set(_cmake_c_compiler "${CMAKE_C_COMPILER}")
endif()
+ if(DEFINED CMAKE_C_COMPILER_TARGET)
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --target=${CMAKE_C_COMPILER_TARGET}")
Review Comment:
this seems to be unintended change, we should not make it as a general
CFLAGS, seems somehting either should be set when invoking tvm cmake, or passed
through into the CONFIGURE command in ExternalProject_Add below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
