kevinthesun commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-tvm/pull/5459#discussion_r426006989



##########
File path: src/relay/op/tensor/transform.cc
##########
@@ -47,6 +47,66 @@ namespace tvm {
 namespace relay {
 using tir::IntImmNode;
 
+int64_t* ToVector(const runtime::NDArray& array) {
+  size_t len = array.Shape().front();
+  int64_t* rel_vec = new int64_t[len];

Review comment:
       Actually I think we don't need ```ToVector``` anymore since 
```ToScalar``` can fully cover and have more supported types. I'll move 
```ToScalar``` to ```pattern_util.h```.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to