areusch commented on a change in pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#discussion_r485000609
########## File path: apps/bundle_deploy/bundle.c ########## @@ -28,6 +29,11 @@ #include "backtrace.h" #endif +#define CRT_MEMORY_NUM_PAGES 16384 +#define CRT_MEMORY_PAGE_SIZE_LOG2 10 Review comment: so actually i'm going the other way with this PR--saying that the backing memory for the memory allocator needs to be allocated by the caller. we can put these into `crt_config.h`, but I'm not sure what the benefit is after this change--the total memory is now passed in to memory.c as an argument. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org