rkimball commented on a change in pull request #6456:
URL: https://github.com/apache/incubator-tvm/pull/6456#discussion_r488103706
##########
File path: src/tir/transforms/lower_custom_datatypes.cc
##########
@@ -97,7 +97,7 @@ class CustomDatatypesLowerer : public StmtExprMutator {
return expr;
}
-#define DEFINE_MUTATE__(OP, NodeName)
\
+#define DEFINE_MUTATE(OP, NodeName)
\
Review comment:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf
section 17.6.4.3.2
For global names:
Each name that contains a double underscore _ _ or begins with an underscore
followed by an uppercase letter (2.12) is reserved to the implementation for
any use.
I never can remember these rules so to simplify things I never start any
name with underscore and never use double underscores. There are cases where it
is fine but I find it too difficult for me to remember when.
This define is within a namespace so I think it might be ok, but why tempt
fate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
