tqchen commented on a change in pull request #6662:
URL: https://github.com/apache/incubator-tvm/pull/6662#discussion_r503333227
##########
File path: src/runtime/vulkan/vulkan.cc
##########
@@ -490,33 +491,17 @@ VulkanDeviceAPI::VulkanDeviceAPI() {
std::vector<VkPhysicalDevice> all_phy_devs(phy_dev_count);
VULKAN_CALL(vkEnumeratePhysicalDevices(instance_, &phy_dev_count,
dmlc::BeginPtr(all_phy_devs)));
for (VkPhysicalDevice phy_dev : all_phy_devs) {
- uint32_t queue_prop_count = 0;
- vkGetPhysicalDeviceQueueFamilyProperties(phy_dev, &queue_prop_count,
nullptr);
- std::vector<VkQueueFamilyProperties> queue_props(queue_prop_count);
- vkGetPhysicalDeviceQueueFamilyProperties(phy_dev, &queue_prop_count,
- dmlc::BeginPtr(queue_props));
- uint32_t queue_family_index = 0;
- std::vector<VkDeviceQueueCreateInfo> queue_create_info;
+ uint32_t queue_family_index = FindComputeQueue(phy_dev);
+ if (queue_family_index == -1U) continue;
Review comment:
Per other commend, maybe it is still helpful to return a vector of
queue_create_info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
