tqchen commented on a change in pull request #6662:
URL: https://github.com/apache/incubator-tvm/pull/6662#discussion_r503934106
##########
File path: src/runtime/vulkan/vulkan.cc
##########
@@ -490,33 +491,24 @@ VulkanDeviceAPI::VulkanDeviceAPI() {
std::vector<VkPhysicalDevice> all_phy_devs(phy_dev_count);
VULKAN_CALL(vkEnumeratePhysicalDevices(instance_, &phy_dev_count,
dmlc::BeginPtr(all_phy_devs)));
for (VkPhysicalDevice phy_dev : all_phy_devs) {
- uint32_t queue_prop_count = 0;
- vkGetPhysicalDeviceQueueFamilyProperties(phy_dev, &queue_prop_count,
nullptr);
- std::vector<VkQueueFamilyProperties> queue_props(queue_prop_count);
- vkGetPhysicalDeviceQueueFamilyProperties(phy_dev, &queue_prop_count,
- dmlc::BeginPtr(queue_props));
- uint32_t queue_family_index = 0;
- std::vector<VkDeviceQueueCreateInfo> queue_create_info;
+ // Get a list of queue families supporting compute, in order of
preference. We currently only
+ // make use of the most preferred one family.
+ std::vector<uint32_t> queue_family_indexes =
GetComputeQueueFamilies(phy_dev);
+ if (queue_family_indexes.empty()) continue;
+ uint32_t queue_family_index = queue_family_indexes[0];
float priority = 1.0f;
- for (uint32_t i = 0; i < queue_props.size(); i++) {
- // find queues that support compute
- if (VK_QUEUE_COMPUTE_BIT & queue_props[i].queueFlags) {
- VkDeviceQueueCreateInfo info;
- info.sType = VK_STRUCTURE_TYPE_DEVICE_QUEUE_CREATE_INFO;
- info.pNext = nullptr;
- info.flags = 0;
- info.queueFamilyIndex = i;
- info.queueCount = 1;
- info.pQueuePriorities = &priority;
-
- queue_create_info.push_back(info);
- // only use the first available queue for now
- if (queue_create_info.size() == 0) {
- queue_family_index = i;
- }
- }
+
+ std::vector<VkDeviceQueueCreateInfo> queue_create_info;
+ for (const auto& index : queue_family_indexes) {
+ struct VkDeviceQueueCreateInfo info {};
Review comment:
In this case, I think we can use your previous logic by using the
`queue_family_index[0]`. and not creating a vector. The GetComputeQueueFamilies
is mainly reserved for future purposes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
