tqchen edited a comment on pull request #6692: URL: https://github.com/apache/incubator-tvm/pull/6692#issuecomment-709642068
In this particular case, ICHECK perhaps should not end up in ir/diagnostic, but instead in `support/logging.h`, moving the marco defs there would be the simplest solution. It would also avoid the dep from runtime to ir ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org