tqchen commented on pull request #6692: URL: https://github.com/apache/incubator-tvm/pull/6692#issuecomment-710126019
As a minimum set of changes to the PR. i would recommend keep the files as they are, and just move the ICHECK defs into `support/logging.h` the additional diagnostics can still be part of the tvm/ir/diagnostic.h, and we do not need the additional context suffix that might cause confusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
