imalsogreg commented on a change in pull request #6741:
URL: https://github.com/apache/incubator-tvm/pull/6741#discussion_r512003693
##########
File path: rust/tvm-macros/src/external.rs
##########
@@ -17,12 +17,32 @@
* under the License.
*/
use proc_macro2::Span;
+use proc_macro_error::abort;
use quote::quote;
use syn::parse::{Parse, ParseStream, Result};
-use syn::{FnArg, Generics, Ident, Lit, Meta, NestedMeta, Pat, ReturnType,
TraitItemMethod, Type};
+use syn::{FnArg, Signature, Attribute, token::Semi, Visibility, Generics,
Ident, Lit, Meta, NestedMeta, Pat, ReturnType, Type};
+
+struct ExternalItem {
Review comment:
nit: brief rustdoc? Some comments would help me get the story of what
`ExternalItem` and `External` are for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
