tqchen commented on pull request #6794: URL: https://github.com/apache/incubator-tvm/pull/6794#issuecomment-719094251
Thanks @tkonolige , given that this is a new op, it would be great to do a API review per https://tvm.apache.org/docs/contribute/code_review.html#deliberate-on-api-and-data-structures In particular, it would be great to checkout the convention of similar APIs in existing frameworks like PyTorch, TensorFlow, we should ideally follow common conventions ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
