slyubomirsky opened a new pull request #7130:
URL: https://github.com/apache/tvm/pull/7130


   As noted in issue #7129, the documentation for `relay.stack` suggests it 
should be able to take a Relay expression that evaluates to a tuple but in 
reality only works for tuple literals or list literals. It was, in fact, easy 
to fix `relay.stack` to work on Relay expressions that evaluate to tuples. I 
have added test cases to show this off.
   
   I would appreciate suggestions for further test cases if possible.
   
   I realize the documentation for `stack` may have been specifically intended 
to mean that its input should always be a tuple literal, but I think it is 
reasonable to expect that it should be able to take an expression evaluate to a 
tuple as input. (The operator implementation and type relation can handle that 
just fine.)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to