jcf94 commented on a change in pull request #7185:
URL: https://github.com/apache/tvm/pull/7185#discussion_r551163552
##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -624,12 +652,10 @@ def local_build_worker(args):
The build result of this Builder thread.
"""
inp, build_func, timeout, verbose = args
- if build_func == "default":
- build_func = tar.tar
- elif build_func == "ndk":
- build_func = ndk.create_shared
- else:
- raise ValueError("Invalid build_func" + build_func)
+ assert build_func == BuildFunc.name, (
+ "BuildFunc.name: " + BuildFunc.name + ", but args is: " + build_func
+ )
+ build_func = BuildFunc.build_func
Review comment:
@FrozenGene @leowang1225
I remember that we have used the global variable here at first. But it was
modified to use serialized args later because of some special reason(which I
have forgetten)
So this way may cause some other problem. I'm thinking that just pass the
registered function name here as a string and this can be serialized easily.
Also cc @merrymercy @comaniac if you can figure out the reason of not using
global variable here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
