leandron commented on a change in pull request #7350:
URL: https://github.com/apache/tvm/pull/7350#discussion_r565364279



##########
File path: docker/install/ubuntu_install_vitis_ai_core.sh
##########
@@ -22,8 +22,9 @@ set -o pipefail
 
 # install libraries for building Vitis-AI on ubuntu
 apt-get update && apt-get install -y --no-install-recommends \
-    graphviz\
-    gnupg2
+    graphviz \
+    gnupg2 \
+    gpg-agent
 
 apt-get update && apt-get install -y gcc-aarch64-linux-gnu

Review comment:
       I understand you removed it from the Dockerfile, to make it clear, and 
that was a good move. However, due to the way Docker layers works, you'll still 
have leftover files, which over time will bloat your image.
   
   The code below is what I had in mind. _To be clear, it's a suggestion only._ 
Feel free to keep your script, if that makes more sense for you.
   
   ```suggestion
       graphviz \
       gnupg2 \
       gpg-agent \
       gcc-aarch64-linux-gnu \
       && rm -rf /var/lib/apt/lists/*
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to