jtuyls commented on a change in pull request #7350:
URL: https://github.com/apache/tvm/pull/7350#discussion_r565427643



##########
File path: docker/install/ubuntu_install_vitis_ai_core.sh
##########
@@ -22,8 +22,9 @@ set -o pipefail
 
 # install libraries for building Vitis-AI on ubuntu
 apt-get update && apt-get install -y --no-install-recommends \
-    graphviz\
-    gnupg2
+    graphviz \
+    gnupg2 \
+    gpg-agent
 
 apt-get update && apt-get install -y gcc-aarch64-linux-gnu

Review comment:
       Ok, thanks, I added `&& rm -rf /var/lib/apt/lists/*` and reorganized a 
bit. I didn't add your suggestion commit as I had to remove 
`--no-install-recommends` to avoid an issue with aarch64-linux-gnu-gcc 
returning the following when using it for cross compilation
   ```
   /usr/lib/gcc-cross/aarch64-linux-gnu/7/../../../../aarch64-linux-gnu/bin/ld: 
cannot find crti.o: No such file or directory
   /usr/lib/gcc-cross/aarch64-linux-gnu/7/../../../../aarch64-linux-gnu/bin/ld: 
cannot find -lc
   /usr/lib/gcc-cross/aarch64-linux-gnu/7/../../../../aarch64-linux-gnu/bin/ld: 
cannot find crtn.o: No such file or directory
   ```
   Ps  `rm -rf /var/lib/apt/lists/*` could be added to the other script files 
too, for example 
https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_core.sh




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to