comaniac commented on a change in pull request #7807:
URL: https://github.com/apache/tvm/pull/7807#discussion_r617736990
##########
File path: tests/python/relay/test_pass_simplify_expr.py
##########
@@ -106,10 +106,112 @@ def expected3():
y = relay.transpose(y, axes=[0, 2, 3, 1])
return relay.Function([x], y)
+ # Test a series of transpose and rank changing layout_transform
+ def before4():
+ x = relay.var("x", shape=(1, 56, 56, 128), dtype="float32") # NHWC
+ y = relay.transpose(x, axes=[0, 3, 1, 2]) # To NCHW
+ y = relay.layout_transform(y, "NCHW", "NCHW4c") # To NCHW4c
+ y = relay.nn.relu(y)
+ y = relay.layout_transform(y, "NCHW4c", "NCHW") # To NCHW
+ y = relay.transpose(y, axes=[0, 2, 3, 1]) # To NHWC
+ return relay.Function([x], y)
+
+ def expected4():
+ x = relay.var("x", shape=(1, 56, 56, 128), dtype="float32") # NHWC
+ y = relay.layout_transform(x, "NHWC", "NCHW4c") # To NCHW4c
+ y = relay.nn.relu(y)
+ y = relay.layout_transform(y, "NCHW4c", "NHWC") # To NHWC
+ return relay.Function([x], y)
+
+ def before5():
+ x = relay.var("x", shape=(1, 56, 56, 128), dtype="float32") # NHWC
+ y = relay.layout_transform(x, "NHWC", "NCHW") # To NCHW
+ y = relay.layout_transform(y, "NCHW", "NCHW4c") # To NCHW4c
+ y = relay.nn.relu(y)
+ y = relay.layout_transform(y, "NCHW4c", "NCHW") # To NCHW
+ y = relay.layout_transform(y, "NCHW", "NHWC") # To NHWC
+ return relay.Function([x], y)
+
+ def expected5():
+ x = relay.var("x", shape=(1, 56, 56, 128), dtype="float32") # NHWC
+ y = relay.layout_transform(x, "NHWC", "NCHW4c") # To NCHW4c
+ y = relay.nn.relu(y)
+ y = relay.layout_transform(y, "NCHW4c", "NHWC") # To NHWC
+ return relay.Function([x], y)
+
+ def before6():
+ x = relay.var("x", shape=(1, 56, 56, 128), dtype="float32") # NHWC
Review comment:
According to the following transforms this should be
```suggestion
x = relay.var("x", shape=(1, 56, 56, 128), dtype="float32") # NCHW
```
but its shape looks like NHWC. Please correct either of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
