stoa commented on pull request #7742: URL: https://github.com/apache/tvm/pull/7742#issuecomment-856190683
@areusch Hello, Andrew Very good - our understanding is aligned. I had imagined the same schema as yours but currently the 'c_backend_api' includes the 'c_runtime_api' and I tried to keep the relation. This simplifies the problem: all we need to do is to move the defines 'TVM_DLL' from the 'c_runtime_api' to the 'c_backend_api'; move the 'g_last_error' from the 'c_runtime_api' to the 'c_backend_api'; include the 'c_backend_api.h' from the 'c_runtime_api'. Concerning the 'AI_API_' - sorry for the confusion, I do not pretend to push this prefix. The stm32 AI_API_ has a few additional defines on top of the 'c_runtime_api' TVM_DLL and TVM_WEAK. I was proposing to add those as TVM_ defines as well We can clean this up later. For now I will keep the stm32 defines with the ai_platform.h. We prefer keep the source code with 'src/runtime/contrib/stm32' and I will reformat the code. I will align the PR and we'll discuss the next step. Arthur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
