stoa commented on pull request #7742: URL: https://github.com/apache/tvm/pull/7742#issuecomment-872796133
@areusch Hello Andrew I cannot just move the TVMLastError to c_backend because then the c_runtime will depend on c_backend and the c_backend already depends on c_runtime. From our previous exchange we agreed that we want c_runtime depend on c_backend, so I moved the minimum of code from c_runtime to c_backend that had to be moved in order to respect this dependency. I can move these changes to a separate PR, even give it more work, because I really moved the minimum possible. However, I would like to close this PR first. Therefore, I am proposing back what I have suggested earlier: I duplicate the TVMLastError functionality inside out platform-specific implementation (we do not link c_runtime_api.c) and I'd take care of aligning the c-backend vs c_runtime functionality after that. How about this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
