robo-corg commented on a change in pull request #8725:
URL: https://github.com/apache/tvm/pull/8725#discussion_r693237923
##########
File path: rust/tvm-rt/src/function.rs
##########
@@ -196,8 +204,8 @@ impl TryFrom<RetValue> for Function {
}
}
-impl<'a> From<Function> for ArgValue<'a> {
- fn from(func: Function) -> ArgValue<'a> {
+impl<'a> From<&Function> for ArgValue<'a> {
Review comment:
Looks good. Thought maybe ToFunction or Function's handles might be able
to produce a dangling reference and I don't think it can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
