robo-corg commented on a change in pull request #8725:
URL: https://github.com/apache/tvm/pull/8725#discussion_r693238152



##########
File path: rust/tvm-rt/src/to_function.rs
##########
@@ -232,13 +270,18 @@ macro_rules! impl_typed_and_to_function {
             }
 
             #[allow(non_snake_case)]
-            fn call(handle: *mut Self::Handle, args: Vec<ArgValue<'static>>) 
-> Result<RetValue>
+            fn call<'a>(handle: *mut Self::Handle, args: Vec<ArgValue<'a>>) -> 
Result<RetValue>

Review comment:
       Poked around at this with tests and the Box that is added makes it safe




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to