mbs-octoml commented on a change in pull request #9012:
URL: https://github.com/apache/tvm/pull/9012#discussion_r709643127
##########
File path: include/tvm/runtime/logging.h
##########
@@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() {
return state == 1;
}
+/*! \brief Helpers for \p VerboseLoggingEnabled. Exposed for unit testing
only. */
+std::unordered_map<std::string, int> ParseTvmLogDebugSpec(const char*
opt_spec);
+bool VerboseEnabledInMap(const std::string& filename, int level,
+ const std::unordered_map<std::string, int>& map);
+
+/*!
+ * \brief Returns true if a VLOG statement in \p filename is enabled by the \p
TVM_LOG_DEBUG
+ * environment variable for logging at verbosity \p level.
+ *
+ * Filenames are canonicalized to be w.r.t. the src/ dir of the TVM tree.
(VLOG's should not
+ * appear under include/).
+ *
+ * To enable file \p relay/foo.cc up to level 2 and \p ir/bar.cc for level 0
only set:
+ * \code
+ * TVM_LOG_DEBUG="1;relay/foo.cc=2;ir/bar.cc=0;"
+ * \endcode
+ *
+ * To enable all files up to level 3 but disable \p ir/bar.cc set:
+ * \code
+ * TVM_LOG_DEBUG="1;*=2;ir/bar.cc=-1;"
Review comment:
I definitely agree with you the ergonomics are horrible! Using an env
variable at all is already unfortunate but forced on us by the
python-is-the-driver convention for TVM. But I think this is all very temporary
and 'for developers only' while we figure out a more structured approach to
controlling, capturing and redirecting logging, including both 'for debug'
logging as well as logging which may be relevant to downstream customers
running tvm in a production environment.
(+ @jroesch since we were chatting about this today).
At this point the CI is green -- do you feel strongly enough we should not
proceed as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
