huajsj commented on a change in pull request #9012:
URL: https://github.com/apache/tvm/pull/9012#discussion_r709691953
##########
File path: include/tvm/runtime/logging.h
##########
@@ -409,6 +416,68 @@ inline bool DebugLoggingEnabled() {
return state == 1;
}
+/*! \brief Helpers for \p VerboseLoggingEnabled. Exposed for unit testing
only. */
+std::unordered_map<std::string, int> ParseTvmLogDebugSpec(const char*
opt_spec);
+bool VerboseEnabledInMap(const std::string& filename, int level,
+ const std::unordered_map<std::string, int>& map);
+
+/*!
+ * \brief Returns true if a VLOG statement in \p filename is enabled by the \p
TVM_LOG_DEBUG
+ * environment variable for logging at verbosity \p level.
+ *
+ * Filenames are canonicalized to be w.r.t. the src/ dir of the TVM tree.
(VLOG's should not
+ * appear under include/).
+ *
+ * To enable file \p relay/foo.cc up to level 2 and \p ir/bar.cc for level 0
only set:
+ * \code
+ * TVM_LOG_DEBUG="1;relay/foo.cc=2;ir/bar.cc=0;"
+ * \endcode
+ *
+ * To enable all files up to level 3 but disable \p ir/bar.cc set:
+ * \code
+ * TVM_LOG_DEBUG="1;*=2;ir/bar.cc=-1;"
Review comment:
If we agree that is a problem , that sound not make sense not to fix it,
and better to avoid a temporary solution that in some case will become a
permanent solution, as a user for this VLOG feature, I like the idea filtering
in file level, but I think such configuration method is unnecessary
complicated and error-prone, if we can better to find a more easy to use
method.
about CI is green, I can understand the CI consume time and sometime it also
random fail, to get it become green not very easy, but from my point view we
should better to more focus on code logic instead of CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
