PhilippvK opened a new pull request #9255:
URL: https://github.com/apache/tvm/pull/9255


   Overview of changes:
   - Updates value of `TVM_CRT_MAX_STRLEN_FUNCTION_NAME` from `80` to `120`
   - Replaces all occurences of `[120]` with 
`[TVM_CRT_MAX_STRLEN_FUNCTION_NAME]` to maintain consistency and make the array 
lengths user-configurable.
   - Introduces `TVM_CRT_MAX_STRLEN_PARAM_NAME` used for parameter names only
   - Adds comments to `kMaxFuncNameLength` variabe in 
src/relay/backend/te_compiler_cache.cc making sure that the values are kept "in 
sync". (sort of)
   
   See Issue #8953 for more context. The actual bug reported there however can 
only be fixed by increasing the TVM_CRT_MAX_STRLEN_FUNCTION_NAME to `121` as 
demonstrated here:
   
   https://github.com/PhilippvK/tvm/commits/bug-demo-fixed
   
   ---
   
   CC @areusch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to