areusch commented on a change in pull request #9255:
URL: https://github.com/apache/tvm/pull/9255#discussion_r728621033
##########
File path: src/runtime/crt/crt_config-template.h
##########
@@ -49,7 +49,10 @@
#define TVM_CRT_MAX_STRLEN_DLTYPE 10
/*! Maximum supported string length in function names */
-#define TVM_CRT_MAX_STRLEN_FUNCTION_NAME 80
+#define TVM_CRT_MAX_STRLEN_FUNCTION_NAME 120
+
+/*! Maximum supported string length in parameter names */
+#define TVM_CRT_MAX_STRLEN_PARAM_NAME 80
Review comment:
i think the main thing is that it's configurable in `crt_config.h` and
we pick a sane default. we can consider a sane default to:
1. fit most parameters and inputs/outputs
2. not be so excessively large as to take too much memory
I guess 80 was chosen before (i inherited this code so am not sure why). it
seems like we could choose something smaller e.g. 20, but on the other hand
it's configurable now and by not changing things, this PR is just a cleanup PR.
so happy to merge as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
