ekalda commented on a change in pull request #9521:
URL: https://github.com/apache/tvm/pull/9521#discussion_r752112202
##########
File path: python/tvm/relay/op/contrib/ethosu.py
##########
@@ -537,9 +538,14 @@ def is_valid(self):
"""
if np.dtype(self.ofm) == np.int32 and self.activation is not None:
Review comment:
Does this mean that a graph with 32 bit OFMs will be offloaded (provided
that there is no activation function)?
##########
File path: tests/python/contrib/test_ethosu/test_codegen.py
##########
@@ -349,6 +349,7 @@ def representative_dataset():
([1, 2, 3, 4], [1, 2, 3, 4]),
([1, 2, 3, 4], [1, 1, 1, 1]),
([1, 1, 1, 1], [1, 2, 3, 4]),
+ ([1, 4, 4], [4, 1]),
Review comment:
Other cases worth testing are input shape that is less than 4D and the
first dimension is not 1 and 2D and 1D IFMs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
