lhutton1 commented on a change in pull request #9521:
URL: https://github.com/apache/tvm/pull/9521#discussion_r753857217
##########
File path: python/tvm/relay/op/contrib/ethosu.py
##########
@@ -537,9 +538,14 @@ def is_valid(self):
"""
if np.dtype(self.ofm) == np.int32 and self.activation is not None:
Review comment:
I'm hoping I understood this correctly, lmk if not :)
##########
File path: tests/python/contrib/test_ethosu/test_codegen.py
##########
@@ -349,6 +349,7 @@ def representative_dataset():
([1, 2, 3, 4], [1, 2, 3, 4]),
([1, 2, 3, 4], [1, 1, 1, 1]),
([1, 1, 1, 1], [1, 2, 3, 4]),
+ ([1, 4, 4], [4, 1]),
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
