masahi commented on a change in pull request #10773:
URL: https://github.com/apache/tvm/pull/10773#discussion_r834724420
##########
File path: python/tvm/relay/op/strategy/arm_cpu.py
##########
@@ -88,20 +88,21 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
if groups == 1:
if layout == "NCHW":
if kernel_layout == "OIHW":
- # ARM conv2d spatial pack schedule.
- strategy.add_implementation(
- wrap_compute_conv2d(topi.arm_cpu.conv2d_nchw_spatial_pack),
-
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nchw_spatial_pack),
- name="conv2d_nchw_spatial_pack.arm_cpu",
- )
-
if topi.arm_cpu.is_int8_hw_support(data.dtype, kernel.dtype):
strategy.add_implementation(
wrap_compute_conv2d(topi.arm_cpu.conv2d_nchw_int8),
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nchw_int8),
name="conv2d_nchw_int8.arm_cpu",
)
else:
+ # ARM conv2d spatial pack schedule.
+ strategy.add_implementation(
+
wrap_compute_conv2d(topi.arm_cpu.conv2d_nchw_spatial_pack),
+
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nchw_spatial_pack),
+ name="conv2d_nchw_spatial_pack.arm_cpu",
+ plevel=10,
+ )
+
Review comment:
`schedule_conv2d_nchw_spatial_pack` has tophub entries, so they are
always picked up based on "time cost" even if `topi.arm_cpu.is_int8_hw_support`
path is taken and the NCHWc int8 schedule is surely faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
