u99127 commented on a change in pull request #10773:
URL: https://github.com/apache/tvm/pull/10773#discussion_r835338505
##########
File path: tests/python/topi/python/test_topi_conv2d_int8.py
##########
@@ -370,29 +352,42 @@ def get_ref_data():
lambda a, w, s, p, d, l, ol, o: topi.cuda.conv2d_NCHWc_int8(a, w,
s, p, d, l, o),
topi.cuda.schedule_conv2d_NCHWc_int8,
4,
+ False,
),
# Disable on CI since it does not support spirv int8 dot product
# (
# "vulkan -from_device=0",
# lambda a, w, s, p, d, l, ol, o: topi.cuda.conv2d_NCHWc_int8(a,
w, s, p, d, l, o),
# topi.cuda.schedule_conv2d_NCHWc_int8,
# 4,
+ # False,
# ),
]
- # TODO(Mousius) Re-enable once implementation is fixed
- # if in_dtype == "int8":
- # targets.append(
- # (
- # "llvm -device arm_cpu -mtriple aarch64-linux-gnu
-mattr=+neon",
- # topi.arm_cpu.conv2d_NCHWc_int8,
- # topi.arm_cpu.schedule_conv2d_NCHWc_int8,
- # 8,
- # )
- # )
-
- for target, compute, schedule, oc_block_factor in targets:
- check_target(target, compute, schedule, oc_block_factor)
+ # TODO(tvm-team): Properly run ARM code on CI aarch64 environment
+ targets.append(
+ (
+ "llvm -device arm_cpu -mtriple aarch64-linux-gnu
-mattr=+neon,+v8.2a,+dotprod",
Review comment:
Not all AArch64 hardware has the dot product i.e. if someone runs the
test suite on a Raspberry pi , this script will fail .
The AWS instance has the dot product instruction, thus perhaps this needs to
be guarded with a check for the underlying hardware supports the dot product
instruction.
/proc/cpuinfo should contain asimddp for that particular feature .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
