jwfromm commented on code in PR #11047:
URL: https://github.com/apache/tvm/pull/11047#discussion_r855630242
##########
python/tvm/relay/op/dyn/_transform.py:
##########
@@ -45,12 +45,15 @@ def _reshape_shape_func_input_data(data_shape, newshape,
ndim):
for i in const_range(len(newshape)):
if skip > 0:
skip -= 1
- elif newshape[i] > 0:
+ elif newshape[i] >= 0:
out[dst_idx] = int64(newshape[i])
src_idx += 1
dst_idx += 1
elif newshape[i] == 0:
Review Comment:
Yes you're right, I think this is a mistake that got left over during
debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
