guberti commented on code in PR #12521:
URL: https://github.com/apache/tvm/pull/12521#discussion_r952396506
##########
python/tvm/autotvm/task/dispatcher.py:
##########
@@ -238,12 +246,12 @@ class ApplyHistoryBest(DispatchContext):
Parameters
----------
- records : str, list of str, or iterator of (autotvm.measure.MeasureInput,\
- autotvm.measure.MeasureResult)
- Collection of tuning records.
- If is str, then it should be the filename of a records log file.
- Each row of this file is an encoded record pair. If it is a list, it
can either be
- a list of paths to log files that will be loaded jointly or an
iterator or records.
+ records : Records or iterator of Records objects, where a Records
Review Comment:
I don't think supporting `Iterator[Records]`makes any sense, and would love
to get rid of this functionality. However, the function `ApplyHistoryBest`
currently supports taking as input an iterator of `str` paths, so removing this
would break previously existing functionality. Thoughts @areusch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
