guberti commented on PR #12521:
URL: https://github.com/apache/tvm/pull/12521#issuecomment-1223847059
@areusch I addressed your minor comments, but I think there is a broader
discussion to be had about what types of arguments `ApplyHistoryBest` should
take. Taking `Union[Records, Iterable[Records]]` is the "least bad" solution
IMO that preserves all existing functionality, such as the ability to pass
`Iterable[str]` (e.g. a list of filepaths) and `Iterable[Tuple[MeasureInput,
MeasureResult]]`.
If we're OK with breaking some rarely used functionality, though, this could
be simplified a lot. `autotvm.callback.log_to_file` supports writing to and
only to file-like and path-like objects, so if we wanted `ApplyHistoryBest` and
`ApplyGraphBest` to match, I would change the function signature to:
```python
class ApplyHistoryBest(DispatchContext):
...
def load(self, records: Union[str, bytes, PathLike, TextIOBase]):
```
What's your opinion here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
