jverma-quic commented on PR #12971: URL: https://github.com/apache/tvm/pull/12971#issuecomment-1268953886
> @jverma-quic this is pretty awesome! I've wanted something like this for a while. > > Thinking longer-term, I'd like to see this supported for more targets than hexagon. Maybe we could discuss (not in this PR) how we could integrate this work into the existing profiling tools. I'd especially love to see support for different runtime metrics (hardware counters, etc). Do you think it would be possible to integrate the (`MetricCollector`)[https://github.com/apache/tvm/blob/main/include/tvm/runtime/profiling.h#L278] interface into this? (Once again, I'm just thinking about the future. Its not necessary for this PR) @tkonolige - Thanks for the review comments and for suggestions for the future enhancements! Let me look into MetricCollector to see if it can be integrated with what I have here. The only part that makes it Hexagon specific is the LLVM intrinsic (which doesn't have to be hexagon specific) and its lowering in LLVM backend to a hexagon specific handler function that collects runtime data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
