junrushao commented on code in PR #13017:
URL: https://github.com/apache/tvm/pull/13017#discussion_r991292671
##########
src/relay/op/vm/vm.cc:
##########
@@ -107,7 +107,7 @@ TVM_REGISTER_GLOBAL("relay.op.vm.invoke_tvm_op")
.set_body_typed([](Expr func, Expr inputs, Expr outputs, DictAttrs attrs) {
return InvokeTVMOp(std::move(func), std::move(inputs),
std::move(outputs), std::move(attrs));
});
-
+TVM_REGISTER_NODE_TYPE(DictAttrsNode);
Review Comment:
It's definitely interesting to hear! As you mentioned, there exists a global
static variable `vm.invoke_tvm_op` that depends on `DictAttrs` - which sounds
to me is a design failure, because it is always assumed that there isn't such
compiler-dependent behavior (static initialization order). Would love to see if
there is an option to fix such behavior instead.
Chinese translation: 这个行为确实挺有趣的。不过我们设计这个系统的时候，希望不要有这种依赖于编译器的行为发生
(全局静态的初始化顺序)，所以不知道能不能帮忙指出 `vm.invoke_tvm_op` 这个全局变量在哪里呢？我想看看能不能修掉。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
